WillAyd commented on code in PR #15041:
URL: https://github.com/apache/arrow/pull/15041#discussion_r1059189441
##########
cpp/src/arrow/compute/kernels/vector_sort_benchmark.cc:
##########
@@ -130,6 +164,18 @@ static void ArraySortIndicesBool(benchmark::State& state) {
ArraySortFuncBoolBenchmark(state, SortRunner(state));
}
+static void ArraySortIndicesString(benchmark::State& state) {
+ const auto min_length = 0;
+ const auto max_length = 32;
Review Comment:
No strong preference, though I think this way if we wanted to try more
combinations of benchmarks in the future it would be easier to extend
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
