tustvold commented on code in PR #4721:
URL: https://github.com/apache/arrow-datafusion/pull/4721#discussion_r1056695809
##########
datafusion/core/src/execution/context.rs:
##########
@@ -559,11 +573,9 @@ impl SessionContext {
}
Ok(false)
}
- /// Creates a logical plan.
- ///
- /// This function is intended for internal use and should not be called
directly.
- #[deprecated(note = "Use SessionContext::sql which snapshots the
SessionState")]
- pub fn create_logical_plan(&self, sql: &str) -> Result<LogicalPlan> {
+
+ /// Creates a [`LogicalPlan`] from a SQL query.
+ pub fn plan_sql(&self, sql: &str) -> Result<LogicalPlan> {
Review Comment:
It is also problematic for the same reason that create_logical_plan is
problematic - it returns a LogicalPlan without any mechanism to
optimise/execute against the same state
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
