alamb commented on code in PR #4721:
URL: https://github.com/apache/arrow-datafusion/pull/4721#discussion_r1056812534


##########
datafusion/core/src/execution/context.rs:
##########
@@ -559,11 +573,9 @@ impl SessionContext {
         }
         Ok(false)
     }
-    /// Creates a logical plan.
-    ///
-    /// This function is intended for internal use and should not be called 
directly.
-    #[deprecated(note = "Use SessionContext::sql which snapshots the 
SessionState")]
-    pub fn create_logical_plan(&self, sql: &str) -> Result<LogicalPlan> {
+
+    /// Creates a [`LogicalPlan`] from a SQL query.
+    pub fn plan_sql(&self, sql: &str) -> Result<LogicalPlan> {

Review Comment:
   > Again this appears to just call DFParser followed by the query planner
   
   Yes that is exactly what it does. 
   
   There needs to be some way for users to create a LogicalPlan and get 
datafusion to optimize and run it properly it (e.g. if the user makes the 
LogicalPlan directly from their own query language such as influxrpc or 
VegaFusion)
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to