Dandandan commented on PR #4730: URL: https://github.com/apache/arrow-datafusion/pull/4730#issuecomment-1365492944
> > I wonder if it might be worth adding some test to ensure this API is not accidentally broken / removed as part of some future refactoring > > The API dos not add new functionality. It provides a bridge to access the compression function in `arrow-rs`. I don't think 'someone might remove it' is a good reason to add test. The person removing the code might also remove the test. If anyone ends up accidentally removing it, then the integration with `arrow-ballista` will fail. I don't see a need to add new test for this. Thank you very mucht for adding this feature, no worries for the test! In some cases, features might be lost by someone moving / refactoring the code as part of another change - this happened quite a few times before in arrow-rs / arrow-datafusion! Tests covering those code paths help avoiding issues like that. In ballista this might be only discovered once the version is updated (which may be only after a new version is released). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
