askoa commented on PR #4730: URL: https://github.com/apache/arrow-datafusion/pull/4730#issuecomment-1365506732
> In some cases, features might be lost by someone moving / refactoring the code as part of another change - this happened quite a few times before in arrow-rs / arrow-datafusion! Tests covering those code paths help avoiding issues like that. In ballista this might be only discovered once the version is updated (which may be only after a new version is released). I don't know the scenarios you are referring to. But during those refactoring the person might remove the test along with the code. So, in my opinion, catching when `arrow-ballista` consumes the changes is the best way to catch such issues rather than adding tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
