alamb commented on code in PR #4762:
URL: https://github.com/apache/arrow-datafusion/pull/4762#discussion_r1058314888
##########
datafusion/core/src/config.rs:
##########
@@ -134,9 +135,9 @@ pub const OPT_HASH_JOIN_SINGLE_PARTITION_THRESHOLD: &str =
/// Definition of a configuration option
pub struct ConfigDefinition {
/// key used to identifier this configuration option
- key: String,
+ key: Cow<'static, str>,
Review Comment:
What would you think about using `Arc` here instead?
`Arc` might would be more consistent with the rest of the DataFusion
codebase as well as help systems like Ballista where the configuration was
serialized / deserialized.
I believe with a `Cow` and without any extra work, the deserialized
`ConfigOptions` will still be owned (and copied) Strings
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
