tustvold commented on code in PR #4762:
URL: https://github.com/apache/arrow-datafusion/pull/4762#discussion_r1058321426
##########
datafusion/core/src/config.rs:
##########
@@ -134,9 +135,9 @@ pub const OPT_HASH_JOIN_SINGLE_PARTITION_THRESHOLD: &str =
/// Definition of a configuration option
pub struct ConfigDefinition {
/// key used to identifier this configuration option
- key: String,
+ key: Cow<'static, str>,
Review Comment:
Hmm... You raise a good point r.e. serialization, perhaps we should just
make ConfigOptions a struct... I'll leave this open if anyone else has any
thoughts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
