[GitHub] [arrow] mapleFU commented on issue #14923: [C++][Parquet] DeltaBitPackDecoder expects all miniblock bitwidths to be present for the last block

[GitBox]

mapleFU commented on issue #14923:
URL: https://github.com/apache/arrow/issues/14923#issuecomment-1366671211

   And after gothrough the code in `DeltaBitPackDecoder`, I found it a bit 
hacking for border handling. Get internal will have:
   
   ```c++
     int GetInternal(T* buffer, int max_values) {
       max_values = static_cast<int>(std::min<int64_t>(max_values, 
total_value_count_));
       if (max_values == 0) {
         return 0;
       }
   ```
   
   So, once it reaches the last block, it will just read the last mini-block 
with data, the remaining buffer will not be read or checked.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org