ygf11 commented on code in PR #4760:
URL: https://github.com/apache/arrow-datafusion/pull/4760#discussion_r1058874708
##########
datafusion/core/tests/sql/joins.rs:
##########
@@ -2452,29 +2452,29 @@ async fn both_side_expr_key_inner_join() -> Result<()> {
"ProjectionExec: expr=[t1_id@0 as t1_id, t2_id@2 as t2_id,
t1_name@1 as t1_name]",
" ProjectionExec: expr=[t1_id@0 as t1_id, t1_name@1 as
t1_name, t2_id@3 as t2_id]",
" CoalesceBatchesExec: target_batch_size=4096",
- " HashJoinExec: mode=Partitioned, join_type=Inner,
on=[(Column { name: \"t1.t1_id + Int64(12)\", index: 2 }, Column { name:
\"t2.t2_id + Int64(1)\", index: 1 })]",
+ " HashJoinExec: mode=Partitioned, join_type=Inner,
on=[(Column { name: \"t1.t1_id + UInt32(12)\", index: 2 }, Column { name:
\"t2.t2_id + UInt32(1)\", index: 1 })]",
" CoalesceBatchesExec: target_batch_size=4096",
- " RepartitionExec: partitioning=Hash([Column { name:
\"t1.t1_id + Int64(12)\", index: 2 }], 2)",
- " ProjectionExec: expr=[t1_id@0 as t1_id, t1_name@1
as t1_name, t1_id@0 + CAST(12 AS UInt32) as t1.t1_id + Int64(12)]",
+ " RepartitionExec: partitioning=Hash([Column { name:
\"t1.t1_id + UInt32(12)\", index: 2 }], 2)",
Review Comment:
After we move the `ExtractEquijoinPredicate` rule, the optimizer will
1. `Simplify` the expression.
2. Extract join keys from join filter.
Since the `ExtractEquijoinPredicate` can unalias the filter, the result is
the same as #4755 now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
