jackwener commented on code in PR #4760:
URL: https://github.com/apache/arrow-datafusion/pull/4760#discussion_r1059657596


##########
datafusion/optimizer/src/extract_equijoin_predicate.rs:
##########
@@ -387,4 +357,33 @@ mod tests {
 
         assert_plan_eq(&plan, expected)
     }
+
+    #[test]
+    fn join_with_alias_filter() -> Result<()> {

Review Comment:
   BTW, I recommend add a integration-test to show the plan after all rule 
optimize it.



##########
datafusion/optimizer/src/extract_equijoin_predicate.rs:
##########
@@ -387,4 +357,33 @@ mod tests {
 
         assert_plan_eq(&plan, expected)
     }
+
+    #[test]
+    fn join_with_alias_filter() -> Result<()> {

Review Comment:
   👍



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to