kou commented on code in PR #292:
URL: https://github.com/apache/arrow-adbc/pull/292#discussion_r1059140790
##########
.github/workflows/packaging.yml:
##########
@@ -75,12 +141,18 @@ jobs:
- name: Build and test
shell: bash
run: |
- docker-compose run docs
+ pushd adbc
+ docker-compose run \
+ -e SETUPTOOLS_SCM_PRETEND_VERSION=${VERSION} \
Review Comment:
Ah, I didn't consider the docs version.
It's just for building Python modules that are used in the docs. If we don't
specify it, built Python modules have invalid version and can't be installed.
##########
.github/workflows/packaging.yml:
##########
@@ -114,7 +192,12 @@ jobs:
- name: Build and test
shell: bash
run: |
- docker-compose run java-dist
+ pushd adbc/
+ docker-compose run \
+ -e SETUPTOOLS_SCM_PRETEND_VERSION=${VERSION} \
Review Comment:
You're right.
##########
dev/release/01-prepare.sh:
##########
@@ -21,17 +21,21 @@ set -ue
SOURCE_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
-if [ "$#" -ne 3 ]; then
- echo "Usage: $0 <version> <next_version> <rc-num>"
+if [ "$#" -ne 4 ]; then
+ echo "Usage: $0 <arrow-dir> <version> <next_version> <rc-num>"
+ echo "Usage: $0 ../arrow 0.1.0 1.0.0 0"
exit 1
fi
. $SOURCE_DIR/utils-prepare.sh
-version=$1
-next_version=$2
+arrow_dir=$1
+version=$2
+next_version=$3
next_version_snapshot="${next_version}-SNAPSHOT"
-rc_number=$3
+rc_number=$4
+
+export ARROW_SOURCE="$(cd "${arrow_dir}" && pwd)"
Review Comment:
Yes.
`ci/linux-packages/Rakefile` uses this. And `update_versions()` in
`dev/release/utils-prepare.sh` uses `ci/linux-packages/Rakefile` to update
versions for Linux packages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
