lidavidm commented on code in PR #292:
URL: https://github.com/apache/arrow-adbc/pull/292#discussion_r1059144666
##########
.github/workflows/packaging.yml:
##########
@@ -75,12 +141,18 @@ jobs:
- name: Build and test
shell: bash
run: |
- docker-compose run docs
+ pushd adbc
+ docker-compose run \
+ -e SETUPTOOLS_SCM_PRETEND_VERSION=${VERSION} \
Review Comment:
Ah, right.
The main thing I want to make sure of is that the nightly build still has
the "(dev)" version, or else it'll overwrite the docs for a release. I guess
that means we should undo the changes in `conf.py` here, since website_build.sh
uses the version from conf.py to decide whether it's dev or release docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
