askoa commented on code in PR #3411:
URL: https://github.com/apache/arrow-rs/pull/3411#discussion_r1059173845
##########
arrow-string/src/like.rs:
##########
@@ -25,6 +25,135 @@ use arrow_select::take::take;
use regex::Regex;
use std::collections::HashMap;
+trait LikeFunctionTemplate {
+ fn call_utf8<O: OffsetSizeTrait>(
+ left: &GenericStringArray<O>,
+ right: &GenericStringArray<O>,
+ ) -> Result<BooleanArray, ArrowError>;
+ #[cfg(feature = "dyn_cmp_dict")]
+ fn call_dict<K: ArrowPrimitiveType>(
+ left: &DictionaryArray<K>,
+ right: &DictionaryArray<K>,
+ ) -> Result<BooleanArray, ArrowError>;
+}
+
+struct LikeFunction {}
+impl LikeFunctionTemplate for LikeFunction {
+ fn call_utf8<O: OffsetSizeTrait>(
+ left: &GenericStringArray<O>,
+ right: &GenericStringArray<O>,
+ ) -> Result<BooleanArray, ArrowError> {
+ like_utf8(left, right)
+ }
+ #[cfg(feature = "dyn_cmp_dict")]
+ fn call_dict<K: ArrowPrimitiveType>(
+ left: &DictionaryArray<K>,
+ right: &DictionaryArray<K>,
+ ) -> Result<BooleanArray, ArrowError> {
+ like_dict(left, right)
+ }
+}
+struct NLikeFunction {}
+impl LikeFunctionTemplate for NLikeFunction {
+ fn call_utf8<O: OffsetSizeTrait>(
+ left: &GenericStringArray<O>,
+ right: &GenericStringArray<O>,
+ ) -> Result<BooleanArray, ArrowError> {
+ nlike_utf8(left, right)
+ }
+ #[cfg(feature = "dyn_cmp_dict")]
+ fn call_dict<K: ArrowPrimitiveType>(
+ left: &DictionaryArray<K>,
+ right: &DictionaryArray<K>,
+ ) -> Result<BooleanArray, ArrowError> {
+ nlike_dict(left, right)
+ }
+}
+
+struct ILikeFunction {}
+impl LikeFunctionTemplate for ILikeFunction {
+ fn call_utf8<O: OffsetSizeTrait>(
+ left: &GenericStringArray<O>,
+ right: &GenericStringArray<O>,
+ ) -> Result<BooleanArray, ArrowError> {
+ ilike_utf8(left, right)
+ }
+ #[cfg(feature = "dyn_cmp_dict")]
+ fn call_dict<K: ArrowPrimitiveType>(
+ left: &DictionaryArray<K>,
+ right: &DictionaryArray<K>,
+ ) -> Result<BooleanArray, ArrowError> {
+ ilike_dict(left, right)
+ }
+}
+
+struct NILikeFunction {}
+impl LikeFunctionTemplate for NILikeFunction {
+ fn call_utf8<O: OffsetSizeTrait>(
+ left: &GenericStringArray<O>,
+ right: &GenericStringArray<O>,
+ ) -> Result<BooleanArray, ArrowError> {
+ nilike_utf8(left, right)
+ }
+ #[cfg(feature = "dyn_cmp_dict")]
+ fn call_dict<K: ArrowPrimitiveType>(
+ left: &DictionaryArray<K>,
+ right: &DictionaryArray<K>,
+ ) -> Result<BooleanArray, ArrowError> {
+ nilike_dict(left, right)
+ }
+}
+static LIKE_DYN: &str = "like_dyn";
+static N_LIKE_DYN: &str = "nlike_dyn";
+static I_LIKE_DYN: &str = "ilike_dyn";
+static N_I_LIKE_DYN: &str = "nilike_dyn";
+static LIKE_FN: &LikeFunction = &LikeFunction {};
+static N_LIKE_FN: &NLikeFunction = &NLikeFunction {};
+static I_LIKE_FN: &ILikeFunction = &ILikeFunction {};
+static N_I_LIKE_FN: &NILikeFunction = &NILikeFunction {};
Review Comment:
Should I use `lazy_static`? Not sure in what scenarios to use it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
