tustvold commented on code in PR #3411:
URL: https://github.com/apache/arrow-rs/pull/3411#discussion_r1059662116
##########
arrow-string/src/like.rs:
##########
@@ -25,6 +25,53 @@ use arrow_select::take::take;
use regex::Regex;
use std::collections::HashMap;
+macro_rules! dyn_function {
+ ($sql:tt, $fn_name:tt, $fn_utf8:tt, $fn_dict:tt) => {
+#[doc = concat!("Perform SQL `left ", $sql ," right` operation on
[`StringArray`] /")]
+/// [`LargeStringArray`], or [`DictionaryArray`] with values
+/// [`StringArray`]/[`LargeStringArray`].
+///
+/// See the documentation on [`like_utf8`] for more details.
Review Comment:
I think this should be `ilike_utf8` for the ilike kernels. How about
documenting the functions outside the macros?
e.g.
```
/// See the documentation on [`like_utf8`] for more details.
dyn_function!(like_dyn, like_utf8, like_dict);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
