westonpace commented on code in PR #14934:
URL: https://github.com/apache/arrow/pull/14934#discussion_r1060140237
##########
cpp/src/arrow/compute/exec/asof_join_node.cc:
##########
@@ -140,6 +172,17 @@ struct MemoStore {
// Stores last known values for all the keys
struct Entry {
+ Entry() = default;
+
+ Entry(OnType time, std::shared_ptr<arrow::RecordBatch> batch, row_index_t
row)
+ : time(time), batch(batch), row(row) {}
+
+ void swap(Entry& other) {
Review Comment:
We generally discourage mutable references but given this is supposed to be
an analogue of `std::swap` it seems ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
