rtpsw commented on PR #14934: URL: https://github.com/apache/arrow/pull/14934#issuecomment-1369115082
> Sorry for the delay looking at this (Christmas vacation). This looks like a solid addition, though it will need a rebase so I am marking "request changes". Sure. > Is negative tolerance something that is often used? Wouldn't it be more intuitive to specify an absolute tolerance that works in both directions? (e.g. grab the closest entry within 20ms of the LHS in either direction)? @icexelloss brought up the negative tolerance, so he should be able to say more about the use cases. Regarding the idea of both-directions, I still can't speak about the use cases, but my guess is the implementation shouldn't be too hard to include in this PR (likely by changing `bool negative` to an enum). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
