viirya commented on code in PR #3426:
URL: https://github.com/apache/arrow-rs/pull/3426#discussion_r1060149281
##########
arrow-array/src/builder/generic_bytes_dictionary_builder.rs:
##########
@@ -145,27 +122,32 @@ where
/// ```
pub fn new_with_dictionary(
keys_capacity: usize,
- dictionary_values: &StringArray,
- ) -> Result<Self, ArrowError> {
+ dictionary_values: &GenericByteArray<T>,
+ ) -> Result<Self, ArrowError>
+ where
+ <T as ByteArrayType>::Native: AsRef<<T as ByteArrayType>::Native> +
AsRef<[u8]>,
Review Comment:
Yea, that works to remove the constraint.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
