viirya commented on code in PR #3426:
URL: https://github.com/apache/arrow-rs/pull/3426#discussion_r1060152535
##########
arrow-select/src/take.rs:
##########
@@ -592,7 +592,10 @@ where
let s = array.value(index);
- length_so_far += T::Offset::from_usize(s.as_ref().len()).unwrap();
+ length_so_far += T::Offset::from_usize(
+ <<T as ByteArrayType>::Native as AsRef<[u8]>>::as_ref(s).len(),
+ )
+ .unwrap();
values.extend_from_slice(s.as_ref());
Review Comment:
Oh Oh right. I followed the suggestion from the compiler here but I also did
this later. 😅
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
