scsmithr opened a new pull request, #3489: URL: https://github.com/apache/arrow-rs/pull/3489
# Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> Closes https://github.com/apache/arrow-rs/issues/3488 # Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> Use case: We're storing service accounts keys external to where the object store client is being created. We do not want to have to write the key to a file before creating the object store client. This change allows for providing the key directly. # What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> Adds an appropriate method to the GCS object store builder for supplying the service account key directly. Only one of service account path or service account key may be provided, otherwise `build` will return an appropriate error. # Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> An additional method on GCS object store builder. <!--- If there are any breaking changes to public APIs, please add the `breaking change` label. --> There are currently no breaking changes, however I believe the `ServiceAccount` variant for the `GoogleConfigKey` should be renamed to `ServiceAccountPath` to better represent what that option is for. I held off on making that change because I saw that the changelog was already generated for 0.5.3 which includes the new `GoogleConfigKey` stuff which would make that a breaking change. If that's an acceptable breaking change, I'm down to go ahead and do that in this PR as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
