tustvold commented on PR #3489:
URL: https://github.com/apache/arrow-rs/pull/3489#issuecomment-1374796775

   Thank you, makes sense to me. 
   
   > I believe the ServiceAccount variant for the GoogleConfigKey should be 
renamed to ServiceAccountPath to better represent what that option is for.
   
   Yeah, probably not worth introducing a breaking change over, but perhaps we 
could deserialize "service_account_path" and "google_service_account_path" to 
allow for users to opt-in to using a more explicit config key. What do you 
think?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to