felipecrv commented on code in PR #15083:
URL: https://github.com/apache/arrow/pull/15083#discussion_r1064782448
##########
python/pyarrow/includes/libarrow.pxd:
##########
@@ -2489,6 +2489,8 @@ cdef extern from "arrow/compute/exec/aggregate.h"
namespace \
cdef cppclass CAggregate "arrow::compute::Aggregate":
c_string function
shared_ptr[CFunctionOptions] options
+ vector[CFieldRef] target
Review Comment:
I was very confused about that as well! The `GroupBy` code called by Python
ignored the `FieldRef`s coming from the `Aggregate::target` and mapped the
`arguments` to the group-by by position. Now that the code relies on the
`.size()` of `Aggregate::target`, we started having issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
