felipecrv commented on code in PR #15083:
URL: https://github.com/apache/arrow/pull/15083#discussion_r1064818385
##########
cpp/src/arrow/compute/exec/aggregate_node.cc:
##########
@@ -46,14 +46,26 @@ namespace {
void AggregatesToString(std::stringstream* ss, const Schema& input_schema,
const std::vector<Aggregate>& aggs,
- const std::vector<int>& target_field_ids, int indent =
0) {
+ const std::vector<std::vector<int>>& target_fieldsets,
+ int indent = 0) {
*ss << "aggregates=[" << std::endl;
for (size_t i = 0; i < aggs.size(); i++) {
for (int j = 0; j < indent; ++j) *ss << " ";
- *ss << '\t' << aggs[i].function << '('
- << input_schema.field(target_field_ids[i])->name();
+ *ss << '\t' << aggs[i].function << '(';
+ const auto& target = target_fieldsets[i];
+ if (target.size() == 0) {
+ *ss << "*";
+ } else {
+ *ss << input_schema.field(target[0])->name();
+ for (size_t k = 1; k < target.size(); k++) {
+ *ss << ", " << input_schema.field(target[k])->name();
+ }
+ }
if (aggs[i].options) {
- *ss << ", " << aggs[i].options->ToString();
+ auto* options_type = aggs[i].options->options_type();
+ if (options_type->num_properties() > 0) {
Review Comment:
This function is sometimes (maybe at all times) called after NULL
`Aggregate::options` get their `options` replaced by a pointer to a instance of
the default options for that aggregate function.
That happens here
https://github.com/apache/arrow/blob/master/cpp/src/arrow/compute/exec/aggregate_node.cc#L113
So I ended up adding the first function that needs no options at all, but
providing default options is required. So I created a options type with 0
properties. That works as a placeholder for the future, when this function
might require properties.
I could drop all this and make this render the string `count_all(*, {})`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
