felipecrv commented on code in PR #15083:
URL: https://github.com/apache/arrow/pull/15083#discussion_r1064886292
##########
cpp/src/arrow/type.h:
##########
@@ -1692,9 +1692,7 @@ class ARROW_EXPORT FieldRef : public
util::EqualityComparable<FieldRef> {
FieldRef(int index) : impl_(FieldPath({index})) {} // NOLINT
runtime/explicit
/// Construct a nested FieldRef.
- FieldRef(std::vector<FieldRef> refs) { // NOLINT runtime/explicit
- Flatten(std::move(refs));
- }
+ explicit FieldRef(std::vector<FieldRef> refs) { Flatten(std::move(refs)); }
Review Comment:
I was mindful of that, but this wasted a lot of my time and is bound to
waste other people's time if they start dealing with `vector<FieldRef>`
anywhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
