[GitHub] [arrow] wjones127 commented on a diff in pull request #15244: GH-15239: [C++][Parquet] Parquet writer writes decimal as int32/64

[GitBox]

wjones127 commented on code in PR #15244:
URL: https://github.com/apache/arrow/pull/15244#discussion_r1065063565


##########
cpp/src/parquet/properties.h:
##########
@@ -199,7 +199,8 @@ class PARQUET_EXPORT WriterProperties {
           pagesize_(kDefaultDataPageSize),
           version_(ParquetVersion::PARQUET_2_4),
           data_page_version_(ParquetDataPageVersion::V1),
-          created_by_(DEFAULT_CREATED_BY) {}
+          created_by_(DEFAULT_CREATED_BY),
+          integer_annotate_decimal_(false) {}

Review Comment:
   How widespread is support? IIUC, this allows for more compact decimal 
representation when available, which seems like it would be nice to have in 
most cases. The only reason not to, IMO is if most other implementations don't 
support reading this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org