wgtmac commented on code in PR #15244:
URL: https://github.com/apache/arrow/pull/15244#discussion_r1066590878
##########
cpp/src/parquet/arrow/schema.cc:
##########
@@ -354,11 +354,15 @@ Status FieldToNode(const std::string& name, const
std::shared_ptr<Field>& field,
} break;
case ArrowTypeId::DECIMAL128:
case ArrowTypeId::DECIMAL256: {
- type = ParquetType::FIXED_LEN_BYTE_ARRAY;
const auto& decimal_type = static_cast<const
::arrow::DecimalType&>(*field->type());
precision = decimal_type.precision();
scale = decimal_type.scale();
- length = DecimalType::DecimalSize(precision);
+ if (properties.integer_annotate_decimal() && 1 <= precision && precision
<= 18) {
Review Comment:
> Does c++ arrow support converting int32/int64 to decimal128 and decimal256？
decimal128/decimal256 support construction from integers. But the parquet
itself does not use an integer array to represent decimal values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
