omus commented on code in PR #371:
URL: https://github.com/apache/arrow-julia/pull/371#discussion_r1065126861
##########
src/ArrowTypes/src/ArrowTypes.jl:
##########
@@ -344,6 +344,9 @@ function ToArrow(x::A) where {A}
for i = 2:length(x)
@inbounds T = promoteunion(T, typeof(toarrow(x[i])))
end
+ if T === Missing
Review Comment:
Sounds good. I'll try to take care of this and the other outstanding things
this week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
