omus commented on code in PR #371:
URL: https://github.com/apache/arrow-julia/pull/371#discussion_r1067157453
##########
src/ArrowTypes/test/tests.jl:
##########
@@ -144,11 +144,46 @@ v_nt = (major=1, minor=0, patch=0, prerelease=(),
build=())
@test !ArrowTypes.concrete_or_concreteunion(Union{Real, String})
@test !ArrowTypes.concrete_or_concreteunion(Any)
-@test ArrowTypes.ToArrow([1,2,3]) == [1,2,3]
-@test ArrowTypes.ToArrow([:hey, :ho]) == ["hey", "ho"]
-x = ArrowTypes.ToArrow(Any[1, 3.14])
-@test x[1] === 1.0
-@test x[2] === 3.14
-@test ArrowTypes.ToArrow(Any[1, 3.14, "hey"]) == [1.0, 3.14, "hey"]
+@testset "ToArrow" begin
+ x = ArrowTypes.ToArrow([1,2,3])
+ @test x isa Int
+ @test x == [1,2,3]
Review Comment:
Noticed the original tests weren't quite specific enough as
`ArrowTypes.ToArrow([1,2,3]) == [1,2,3]` would continue to pass even if
`ToArrow` would always return `Float64` values for all numeric types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
