lidavidm commented on a change in pull request #8581:
URL: https://github.com/apache/arrow/pull/8581#discussion_r517055362
##########
File path:
java/flight/flight-grpc/src/main/java/org/apache/arrow/flight/FlightGrpcUtils.java
##########
@@ -49,10 +143,10 @@ public static BindableService
createFlightService(BufferAllocator allocator, Fli
/**
* Creates a Flight client.
* @param incomingAllocator Memory allocator
- * @param channel provides a connection to a gRPC server
+ * @param channel provides a connection to a gRPC server. Will not be closed
on closure of the returned FlightClient.
Review comment:
This would be a breaking change - can we do this in a separate method?
##########
File path:
java/flight/flight-grpc/src/main/java/org/apache/arrow/flight/FlightGrpcUtils.java
##########
@@ -19,17 +19,111 @@
import java.util.Collections;
import java.util.concurrent.ExecutorService;
+import java.util.concurrent.TimeUnit;
import org.apache.arrow.flight.auth.ServerAuthHandler;
import org.apache.arrow.memory.BufferAllocator;
+import org.apache.arrow.util.VisibleForTesting;
import io.grpc.BindableService;
+import io.grpc.CallOptions;
+import io.grpc.ClientCall;
+import io.grpc.ConnectivityState;
import io.grpc.ManagedChannel;
+import io.grpc.MethodDescriptor;
/**
* Exposes Flight GRPC service & client.
*/
public class FlightGrpcUtils {
+ /**
+ * Proxy class for ManagedChannel that makes closure a no-op.
+ */
+ @VisibleForTesting
+ static class ProxyManagedChannel extends ManagedChannel {
Review comment:
Lets name this more specifically, perhaps 'NonOwningProxyManagedChannel'
or 'NonClosingProxyManagedChannel'
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
