lidavidm commented on a change in pull request #8581:
URL: https://github.com/apache/arrow/pull/8581#discussion_r517340629
##########
File path:
java/flight/flight-grpc/src/main/java/org/apache/arrow/flight/FlightGrpcUtils.java
##########
@@ -49,10 +143,10 @@ public static BindableService
createFlightService(BufferAllocator allocator, Fli
/**
* Creates a Flight client.
* @param incomingAllocator Memory allocator
- * @param channel provides a connection to a gRPC server
+ * @param channel provides a connection to a gRPC server. Will not be closed
on closure of the returned FlightClient.
Review comment:
Yes - how does that not solve the problem? The caller can choose whether
the FlightClient takes ownership of the channel or not by calling different
methods. But if the current method is modified, then any existing code will
suddenly silently leak channels.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
