vibhatha commented on code in PR #33623:
URL: https://github.com/apache/arrow/pull/33623#discussion_r1067649790
##########
cpp/src/arrow/compute/exec/exec_plan.h:
##########
@@ -426,24 +426,36 @@ struct ARROW_EXPORT Declaration {
/// \brief Utility method to run a declaration and collect the results into a
table
///
+/// \param use_threads If `use_threads` is false then all CPU work will be
done on the
+/// calling thread. I/O tasks will still happen on the I/O
executor
+/// and may be multi-threaded (but should not use
significant CPU
+/// resources)
+/// \param memory_pool The memory pool to use for allocations made while
running the plan.
+/// \param function_registry The function registry to use for function
execution. If null
+/// then the default function registry will be used.
+///
/// This method will add a sink node to the declaration to collect results
into a
/// table. It will then create an ExecPlan from the declaration, start the
exec plan,
/// block until the plan has finished, and return the created table.
-///
-/// If `use_threads` is false then all CPU work will be done on the calling
thread. I/O
-/// tasks will still happen on the I/O executor and may be multi-threaded (but
should
-/// not use significant CPU resources)
-ARROW_EXPORT Result<std::shared_ptr<Table>> DeclarationToTable(Declaration
declaration,
- bool
use_threads = true);
+ARROW_EXPORT Result<std::shared_ptr<Table>> DeclarationToTable(
+ Declaration declaration, bool use_threads = true,
+ MemoryPool* memory_pool = default_memory_pool(),
+ FunctionRegistry* function_registry = NULLPTR);
/// \brief Asynchronous version of \see DeclarationToTable
///
-/// The behavior of use_threads is slightly different than the synchronous
version since
-/// we cannot run synchronously on the calling thread. Instead, if
use_threads=false then
-/// a new thread pool will be created with a single thread and this will be
used for all
-/// compute work.
+/// \param use_threads The behavior of use_threads is slightly different than
the
+/// synchronous version since we cannot run synchronously
on the
+/// calling thread. Instead, if use_threads=false then a
new thread
Review Comment:
```suggestion
/// calling thread. Instead, if use_threads=false then a
new thread
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
