vibhatha commented on code in PR #33623:
URL: https://github.com/apache/arrow/pull/33623#discussion_r1067657150
##########
cpp/src/arrow/engine/substrait/util.cc:
##########
@@ -40,113 +40,15 @@ namespace arrow {
namespace engine {
-namespace {
-
-/// \brief A SinkNodeConsumer specialized to output ExecBatches via
PushGenerator
-class SubstraitSinkConsumer : public compute::SinkNodeConsumer {
Review Comment:
I remember, I am doing a similar cleanup (based on your suggestion) in a
particular PR (surely not merged yet), but I cannot remember where, but it is
better we get this cleaned up and actually this was one of your suggestions as
I can remember.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
