save-buffer commented on code in PR #13669:
URL: https://github.com/apache/arrow/pull/13669#discussion_r1068643299
##########
cpp/src/arrow/compute/light_array.h:
##########
@@ -377,12 +383,17 @@ class ARROW_EXPORT ExecBatchBuilder {
ExecBatch Flush();
int num_rows() const { return values_.empty() ? 0 : values_[0].num_rows(); }
+ bool is_full() const { return num_rows() == num_rows_max(); }
static int num_rows_max() { return 1 << kLogNumRows; }
private:
static constexpr int kLogNumRows = 15;
+ // Align all buffers to 512 bytes so that we can spill them with
+ // DirectIO.
+ static constexpr int64_t kAlignment = 512;
Review Comment:
Added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
