save-buffer commented on code in PR #13669:
URL: https://github.com/apache/arrow/pull/13669#discussion_r1068645018
##########
cpp/src/arrow/compute/exec/hash_join.h:
##########
@@ -35,33 +35,35 @@
namespace arrow {
namespace compute {
-using arrow::util::AccumulationQueue;
-
class HashJoinImpl {
public:
using OutputBatchCallback = std::function<void(int64_t, ExecBatch)>;
using BuildFinishedCallback = std::function<Status(size_t)>;
- using FinishedCallback = std::function<void(int64_t)>;
+ using FinishedCallback = std::function<Status(int64_t)>;
using RegisterTaskGroupCallback = std::function<int(
std::function<Status(size_t, int64_t)>, std::function<Status(size_t)>)>;
using StartTaskGroupCallback = std::function<Status(int, int64_t)>;
using AbortContinuationImpl = std::function<void()>;
+ struct CallbackRecord {
Review Comment:
Mostly just cleanup to be consistent with SpillingJoin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
