alamb opened a new pull request, #4906: URL: https://github.com/apache/arrow-datafusion/pull/4906
# Which issue does this PR close? Inspired by the bug in https://github.com/apache/arrow-datafusion/pull/4900 and discussion with @avantgardnerio on https://github.com/apache/arrow-datafusion/pull/4701#discussion_r1069131341 # Rationale for this change There is no good way to walk all expressions in a LogicalPlan other than to call `LogicalPlan::expressions()` which clones them all # What changes are included in this PR? 1. Add LogicalPlan::inspect_expressions that calls a function on each expression 2. Rewrite subquery traversal to use this this function # Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 3. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> # Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
