alamb commented on code in PR #4906:
URL: https://github.com/apache/arrow-datafusion/pull/4906#discussion_r1070261913
##########
datafusion/expr/src/logical_plan/plan.rs:
##########
@@ -233,42 +233,60 @@ impl LogicalPlan {
/// logical plan node. This does not include expressions in any
/// children
pub fn expressions(self: &LogicalPlan) -> Vec<Expr> {
+ let mut exprs = vec![];
+ self.observe_expressions(|e| exprs.push(e.clone()));
Review Comment:
The basic idea is to refactor the current code to clone all expressions to
just call a function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
