westonpace commented on code in PR #33700:
URL: https://github.com/apache/arrow/pull/33700#discussion_r1071351776
##########
cpp/src/arrow/compute/exec/aggregate_node.cc:
##########
@@ -500,11 +500,28 @@ class GroupByNode : public ExecNode {
int64_t num_output_batches = bit_util::CeilDiv(out_data_.length,
output_batch_size());
outputs_[0]->InputFinished(this, static_cast<int>(num_output_batches));
- RETURN_NOT_OK(plan_->query_context()->StartTaskGroup(output_task_group_id_,
- num_output_batches));
+ Status st =
+ plan_->query_context()->StartTaskGroup(output_task_group_id_,
num_output_batches);
+ if (st.IsCancelled()) {
Review Comment:
This is translating a failed status into a successful status (the test
expects a plan to succeed after calling `StopProducing`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
