westonpace commented on code in PR #33700:
URL: https://github.com/apache/arrow/pull/33700#discussion_r1071353252
##########
cpp/src/arrow/compute/exec/aggregate_node.cc:
##########
@@ -521,7 +538,7 @@ class GroupByNode : public ExecNode {
if (ErrorIfNotOk(Consume(ExecSpan(batch)))) return;
if (input_counter_.Increment()) {
- ErrorIfNotOk(OutputResult());
Review Comment:
Yes, at the moment, the only thing that handles this error is the sink node
and all it will do is trigger an abort which will end up coming back here and
marking this finished anyways.
That used to be needed because it was the only way to trigger an abort on a
failure.
Now, with the async scheduler, any failed task will trigger an abort.
Furthemore, since `finished_` is a "task" it will trigger the abort in this
path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
