zzzzwj commented on code in PR #33703:
URL: https://github.com/apache/arrow/pull/33703#discussion_r1072218248
##########
cpp/src/parquet/column_reader.h:
##########
@@ -151,7 +151,7 @@ class PARQUET_EXPORT PageReader {
}
// @returns: shared_ptr<Page>(nullptr) on EOS, std::shared_ptr<Page>
- // containing new Page otherwise
+ // containing new Page otherwise. This object must not outlive the
PageReader.
Review Comment:
Sorry for the late response. This comment may be incorrect. According to
https://github.com/apache/arrow/issues/14748#issuecomment-1333336429, I think
[emkornfield](https://github.com/emkornfield)'s meaning is that, we need to
make sure that the object "Column(i)" must outlive the "Column(i).get()",
right? If so, this comment should be "shared_ptr\<Page\>" must outlive its
pointer contained (Page *).
I'm not that familiar with C++. I don't know if I understand correctly or
not, if not, please let me know. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
