zeroshade commented on code in PR #355: URL: https://github.com/apache/arrow-adbc/pull/355#discussion_r1072671319
########## python/adbc_driver_flightsqlgo/adbc_driver_flightsqlgo/__init__.py: ########## @@ -0,0 +1,31 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +import importlib.resources + +import adbc_driver_manager + +from ._version import __version__ + +__all__ = ["connect", "__version__"] + + +def connect(uri: str) -> adbc_driver_manager.AdbcDatabase: + """Create a low level ADBC connection to a Flight SQL backend.""" + root = importlib.resources.files(__package__) + entrypoint = root.joinpath("libadbc_driver_flightsqlgo.so") Review Comment: `libadbc_driver_flightsql_go.so` you missed the space between `flightsql` and `go`. Also is there any real reason to explicitly name the package `flightsqlgo`? as opposed to just `flightsql`? Since in theory the .so should be interchangable with any ADBC-compatible driver which implements flightsql? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
