zeroshade commented on code in PR #355:
URL: https://github.com/apache/arrow-adbc/pull/355#discussion_r1081661077
##########
go/adbc/driver/flightsql/flightsql_adbc.go:
##########
@@ -103,6 +103,12 @@ func (d Driver) NewDatabase(opts map[string]string)
(adbc.Database, error) {
return nil, adbc.Error{Msg: err.Error(), Code:
adbc.StatusInvalidArgument}
}
+ if db.uri.Scheme == "grpc+tls" {
+ db.creds = credentials.NewTLS(&tls.Config{})
+ } else {
+ db.creds = insecure.NewCredentials()
+ }
Review Comment:
should this get shifted into `SetOptions` since we do the rest of the
handling for creds there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
