tustvold commented on code in PR #3556:
URL: https://github.com/apache/arrow-rs/pull/3556#discussion_r1073753755
##########
arrow-flight/src/sql/client.rs:
##########
@@ -378,13 +378,13 @@ pub struct PreparedStatement<T> {
impl PreparedStatement<Channel> {
pub(crate) fn new(
- client: Arc<Mutex<FlightServiceClient<Channel>>>,
+ flight_client: FlightServiceClient<Channel>,
Review Comment:
Channel is cheaply cloneable, so there is no reason for the additional
`Arc<Mutex>`
See
https://docs.rs/tonic/latest/tonic/transport/struct.Channel.html#multiplexing-requests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
