alamb commented on code in PR #3556:
URL: https://github.com/apache/arrow-rs/pull/3556#discussion_r1073759794
##########
arrow-flight/src/sql/client.rs:
##########
@@ -124,16 +122,18 @@ impl FlightSqlServiceClient {
let flight_client = FlightServiceClient::new(channel);
FlightSqlServiceClient {
token: None,
- flight_client: Arc::new(Mutex::new(flight_client)),
+ flight_client,
}
}
- fn mut_client(
- &mut self,
- ) -> Result<MutexGuard<FlightServiceClient<Channel>>, ArrowError> {
- self.flight_client
- .try_lock()
- .map_err(|_| ArrowError::IoError("Unable to lock
client".to_string()))
+ /// Return a reference to the underlying [`FlightServiceClient`]
Review Comment:
I also recommend an `into_inner()` function if possible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
