AlenkaF commented on PR #33761: URL: https://github.com/apache/arrow/pull/33761#issuecomment-1397108286
Great work so far @akshaysu12 ! Looking at the code from the binding for `CSVStreamingReader` and the work done on the C++ side for the JSON stream reader I would say this PR is already in a good shape. As you mentioned, you should add the documentation to the https://arrow.apache.org/docs/dev/python/api/formats.html (docs/source/python/api/formats.rst)and https://arrow.apache.org/docs/dev/python/json.html (docs/source/python/json.rst). To build the documentation locally see: https://arrow.apache.org/docs/dev/developers/documentation.html You should also correct the linter error: ```python --- original//arrow/python/pyarrow/tests/test_json.py +++ fixed//arrow/python/pyarrow/tests/test_json.py @@ -106,6 +106,7 @@ check_options_class_pickling(cls, explicit_schema=schema, newlines_in_values=False, unexpected_field_behavior="ignore") + class BaseTestJSON(abc.ABC): @abc.abstractmethod @@ -296,11 +297,12 @@ # Better error output assert table.to_pydict() == expected.to_pydict() + class BaseTestJSONRead(BaseTestJSON): def read_bytes(self, b, **kwargs): return self.read_json(pa.py_buffer(b), **kwargs) - + def test_file_object(self): data = b'{"a": 1, "b": 2}\n' expected_data = {'a': [1], 'b': [2]} @@ -311,7 +313,7 @@ sio = io.StringIO(data.decode()) with pytest.raises(TypeError): self.read_json(sio) - + def test_reconcile_accross_blocks(self): # ARROW-12065: reconciling inferred types across blocks first_row = b'{ }\n' ``` To run the linter locally see: https://arrow.apache.org/docs/dev/developers/python.html#coding-style -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
