Jibbow opened a new pull request #8611: URL: https://github.com/apache/arrow/pull/8611
This PR partly handles the issue https://issues.apache.org/jira/browse/ARROW-4804. Things to discuss: 1. `Date32` currently assumes to have `DateUnit::Day` and `Date64` assumes `DateUnit::Millisecond` respectively. 2. Dates have to be in ISO format `YYY-MM-DD` or `YYY-MM-DDTHH:MM:SS`. I'm not sure if this is a reasonable assumption. It should also be noted that the C++ implementation does not strictly follow the ISO format because it uses `YYY-MM-DD HH:MM:SS` instead (without the `T`). The difference is also a point that has to be discussed before merging. 3. I'm using `std::mem::transmute_copy` to convert `i32` and `i64` to `T::Native`. I struggled with Rust's type system here and I'd appreciate suggestions on how to do this in a less-unsafe way. Things that are not part of this PR: 1. Handling of other temporal types like timestamp and time. 2. No list of columns for temporal types (reference: "To keep inference performant. user should provide a Vec<String> of which columns to try convert to a temporal array") ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
