nevi-me commented on a change in pull request #8611:
URL: https://github.com/apache/arrow/pull/8611#discussion_r520597966



##########
File path: rust/arrow/src/csv/reader.rs
##########
@@ -219,6 +226,35 @@ pub fn infer_schema_from_files(
     Schema::try_merge(&schemas)
 }
 
+/// Parses a string into the specified `ArrowPrimitiveType`.
+fn parse_field<T: ArrowPrimitiveType>(s: &str) -> Result<T::Native> {
+    let from_ymd = chrono::NaiveDate::from_ymd;

Review comment:
       In the long run, this is motivation to centralise this into temporal 
kernels; so we can share this with the JSON reader.
   One of the things I'll submit a PR for in the coming days/weeks, is a crate 
that parses strings to numbers faster than what libcore does.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to