askoa commented on code in PR #3553:
URL: https://github.com/apache/arrow-rs/pull/3553#discussion_r1081793976
##########
arrow-array/src/array/mod.rs:
##########
@@ -737,6 +754,7 @@ pub fn new_null_array(data_type: &DataType, length: usize)
-> ArrayRef {
new_null_sized_decimal(data_type, length,
std::mem::size_of::<i128>())
}
DataType::Decimal256(_, _) => new_null_sized_decimal(data_type,
length, 32),
+ DataType::RunEndEncoded(_, _) => todo!(),
Review Comment:
I think `unimplemented` does not give future guarantees. `todo` indicates
the functionality will be implemented in the future. I think `todo` fits here
more than `unimplemented`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
