askoa commented on code in PR #3553:
URL: https://github.com/apache/arrow-rs/pull/3553#discussion_r1082388443
##########
arrow-array/src/array/mod.rs:
##########
@@ -737,6 +754,7 @@ pub fn new_null_array(data_type: &DataType, length: usize)
-> ArrayRef {
new_null_sized_decimal(data_type, length,
std::mem::size_of::<i128>())
}
DataType::Decimal256(_, _) => new_null_sized_decimal(data_type,
length, 32),
+ DataType::RunEndEncoded(_, _) => todo!(),
Review Comment:
That's a good suggestion and apparently that's the default message
https://github.com/rust-lang/rust/blob/56ee85274e5a3a4dda92f3bf73d1664c74ff9c15/library/core/src/macros/mod.rs#L771-L777
```
macro_rules! todo {
() => {
$crate::panicking::panic("not yet implemented")
};
($($arg:tt)+) => {
$crate::panic!("not yet implemented: {}",
$crate::format_args!($($arg)+))
};
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]