westonpace commented on code in PR #33676:
URL: https://github.com/apache/arrow/pull/33676#discussion_r1082894510
##########
cpp/src/arrow/compute/exec/options.h:
##########
@@ -523,7 +523,8 @@ class ARROW_EXPORT AsofJoinNodeOptions : public
ExecNodeOptions {
///
/// \see `Keys` for details.
std::vector<Keys> input_keys;
- /// \brief Tolerance for inexact "on" key matching. Must be non-negative.
+ /// \brief Tolerance for inexact "on" key matching. Positive (resp.
negative) tolerance
+ /// is interpreted as a future (resp. past) as-of-join.
Review Comment:
The `resp.` abbreviation is unknown to me. Perhaps we can be more explicit
here.
```suggestion
/// \brief Tolerance for inexact "on" key matching. Two rows are only
considered a match
/// if `left.on - right.on < tolerance`. `tolerance` may be
negative and, if so, right side
/// rows may even have a greater `on` value than the left side.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
