westonpace commented on code in PR #33676:
URL: https://github.com/apache/arrow/pull/33676#discussion_r1083291764
##########
cpp/src/arrow/compute/exec/options.h:
##########
@@ -523,7 +523,8 @@ class ARROW_EXPORT AsofJoinNodeOptions : public
ExecNodeOptions {
///
/// \see `Keys` for details.
std::vector<Keys> input_keys;
- /// \brief Tolerance for inexact "on" key matching. Must be non-negative.
+ /// \brief Tolerance for inexact "on" key matching. Positive (resp.
negative) tolerance
+ /// is interpreted as a future (resp. past) as-of-join.
Review Comment:
Out of curiosity, why is it reversed? Doesn't this put us at odds with
pandas which does backwards by default?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
