EpsilonPrime commented on code in PR #33775:
URL: https://github.com/apache/arrow/pull/33775#discussion_r1083734555
##########
cpp/src/arrow/compute/kernels/scalar_round.cc:
##########
@@ -452,6 +468,127 @@ struct Round<ArrowType, kRoundMode,
enable_if_decimal<ArrowType>> {
}
};
+template <typename ArrowType, RoundMode RndMode, typename Enable = void>
+struct RoundBinary {
+ using CType = typename TypeTraits<ArrowType>::CType;
+ using State = RoundOptionsWrapper<RoundBinaryOptions>;
+
+ explicit RoundBinary(const State& state, const DataType& out_ty) {}
+
+ template <typename T = ArrowType, typename CType0 = typename
TypeTraits<T>::CType0,
+ typename CType1 = typename TypeTraits<T>::CType1>
+ enable_if_floating_value<CType> Call(KernelContext* ctx, CType0 arg0, CType1
arg1,
+ Status* st) const {
+ // Do not process Inf or NaN because they will trigger the overflow error
at end of
+ // function.
Review Comment:
Yes, they are in TEST_F(TestBinaryRoundFloating, Round) around line 1161.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
